hubert.reinterpretcast added inline comments.
================
Comment at: clang/test/CodeGenCXX/ibm128-declarations.cpp:25
+
+__ibm128 func4(__ibm128 a, __ibm128 b) {
+ return a + b;
----------------
hubert.reinterpretcast wrote:
> hubert.reinterpretcast wrote:
> > There's a lot of missing testing, especially around implicit conversions,
> > narrowing conversions, and the usual arithmetic conversions.
> >
> Make this a `constexpr` function and call it from the initializer of a global
> declared with `consteval`.
> Make this a `constexpr` function and call it from the initializer of a global
> declared with `consteval`.
Sorry, I meant `constinit` and not `consteval`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93377/new/
https://reviews.llvm.org/D93377
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
