hliao added inline comments.
================ Comment at: clang/lib/CodeGen/TargetInfo.cpp:2821 + } else if (k == BuiltinType::Float16 || k == BuiltinType::Half) { + // AMD64 does not support operations on _Float16 or __fp16 other than + // load and store. For load/store operations, _Float16 and __fp16 is ---------------- pengfei wrote: > This is still not correct I think. As Clang dos says, _Float16 is not support > (including load and store) unless ABI defines it. > We cannot add it before there's clear definition in the ABI. > See https://github.com/hjl-tools/x86-psABI/wiki/x86-64-psABI-1.0.pdf That's quite outdated spec. Please check the latest one from https://gitlab.com/x86-psABIs/x86-64-ABI, which classify _Float16 as SSE. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97318/new/ https://reviews.llvm.org/D97318 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits