mgartmann added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25
+ .bind("match"),
+ this);
+}
----------------
mgartmann wrote:
> riccibruno wrote:
> > Will this match `my_namespace::cin`?
> Yes, at the moment this would be matched as well.
Thinking about it, in my opinion, only matching those objects if they are
coming form the `std` namespace would make more sense and lead to less
"false-positive" diagnostics.
Furthermore, [[ https://www.cevelop.com/ | Cevelop IDE ]]'s check, which is
where the idea for this check came form, also behaves like this.
Thus, I added the `isInStdNamespace()` matcher in the latest diff.
@riccibruno What is your opinion on this? Would it make more sense to also
match e.g., `my_namespace::cin` in your opinion?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99646/new/
https://reviews.llvm.org/D99646
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
