teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
I believe everything I pointed out so far has been resolved. I still have one
more nit about the unit test though (just to not make it fail on some Windows
setups).
FWIW, given that this is in quite the raw state at the moment, I wonder if we
should actually keep it out of the list of installed binaries until it reaches
some kind of MVP state. Once this landed this otherwise gets shipped as part of
the next clang release and shows up in people's shells.
================
Comment at: clang/unittests/Interpreter/InterpreterTest.cpp:86
+
+ EXPECT_DEATH((void)Interp->Parse("int var1 = 42;"), "");
+}
----------------
You still need a `#ifdef GTEST_HAS_DEATH_TEST` around this (death tests aren't
supported on some specific setups)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96033/new/
https://reviews.llvm.org/D96033
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
