vsavchenko added a comment.

Hey folks!

I was thinking that this method can be quite handy.
I think it would be great to have another pair of eyes (but more would be 
better) to look into this and:

- Suggest other test cases to add
- See if I missed any "typed" values from the hierarchy
- See if `getType` for supported types does make sense

In particular, it would be great to hear your thoughts on `SymolicRegion` 
because it's not that obvious that we should return that type or not.  On one 
hand, this is the best we've got, on the other hand, it can be misleading.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104550/new/

https://reviews.llvm.org/D104550

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to