dblaikie added a comment. In D104619#2846255 <https://reviews.llvm.org/D104619#2846255>, @nridge wrote:
> I based the infrastructure closely on that in `DeclPrinterTest.cpp` and > `StmtPrinterTest.cpp`. I figured the general framework could come in useful > to people adding new type printing tests in the future. > > I'm happy to trim it down a bit (e.g. remove unused methods and such), but in > terms of the general approach, I feel like there's value in being consistent > with the other printer tests? Ah, sorry, had meant to ask if it'd be inspired by something else - if that's the case, maybe there's room to refactor the commonality - avoiding the near(if it is near) duplication and justifying the complexity/more general design a bit more, by having more uses to generalize over? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104619/new/ https://reviews.llvm.org/D104619 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
