dgoldman added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:1122
+ AllOf(WithName("someFunctionAbove")),
+ // FIXME: This should be nested under MYObject below.
+ AllOf(WithName("someHelperFunction")),
----------------
kadircet wrote:
> yikes, this looks bad, but also a little bit confusing to be added with this
> change. Can you move it to a separate one? (or just create a bug report in
> github/clangd/clangd).
I'm not sure this is worth disregarding just yet, if we're not able to fix this
at the clang level we might want to consider a clangd-style fix here (which
actually would behave similar to what we have right now with the text marks
needing to be merged in).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105904/new/
https://reviews.llvm.org/D105904
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
