Re: [PATCH] D20383: PCH + Module: make sure we write out macros associated with builtin identifiers

[Manman Ren via cfe-commits]

manmanren added a comment.

Thanks Bruno


================
Comment at: lib/Serialization/ASTWriter.cpp:2191
@@ -2191,1 +2190,3 @@
+    // We write out exported module macros for PCH as well.
+    if (true) {
       auto Leafs = PP.getLeafModuleMacros(Name);
----------------
bruno wrote:
> Is this intended?
I was trying to make sure people get that it is the only thing this patch 
changes :) I will remove it if we are okay with this approach.



http://reviews.llvm.org/D20383



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits