aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM! > Since the other branch has never been used I wonder if we should just remove > it instead? I don't think removing the other branch entirely is a good approach because then the call will silently be a noop when threads are disabled. I'd rather we keep the support, or turn the other branch into a loud breakage so that callers of it find out at compile time that it's not supported when threads are disabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108110/new/ https://reviews.llvm.org/D108110 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
