yaxunl added a comment. In D103835#2999545 <https://reviews.llvm.org/D103835#2999545>, @arichardson wrote:
> Merging this change broke our out-of-tree CHERI targets (and Arm Morello). We > use addrspace(200) for *all* globals (including vtables). It would have been > nice if I had been added to this review considering that I added line you are > changing here. > > If vtables are not in the default globals address space, I think we need > another way of expressing this. I think > `CGM.getContext().getTargetAddressSpace(LangAS::Default))` should also be > correct for your use-case? vtbl addr space should be the same as `this` pointer. If I use addr space of `this` pointer and not assuming it is default addr space, will it work for you? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103835/new/ https://reviews.llvm.org/D103835 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
