ABataev added inline comments.
================
Comment at: clang/include/clang/AST/OpenMPClause.h:334
+/// value of 8.
+class OMPAlignClause : public OMPClause {
+ friend class OMPClauseReader;
----------------
`final`
================
Comment at: clang/include/clang/AST/OpenMPClause.h:362-364
+ /// Sets the location of '('.
+ void setLParenLoc(SourceLocation Loc) { LParenLoc = Loc; }
+
----------------
Also worth to make it private
================
Comment at: clang/include/clang/AST/OpenMPClause.h:377-382
+ child_range used_children() {
+ return child_range(child_iterator(), child_iterator());
+ }
+ const_child_range used_children() const {
+ return const_child_range(const_child_iterator(), const_child_iterator());
+ }
----------------
IIRC, must return same as `children` here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112577/new/
https://reviews.llvm.org/D112577
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
