ZarkoCA added a comment.

In D113211#3110171 <https://reviews.llvm.org/D113211#3110171>, @jkorous wrote:

> Hi! Thank you for the clean-up :)
>
> I feel there might be a bit of work still left. While renaming filenames and 
> function names should be mostly inconsequential renaming command line options 
> and sanitizer ignorelist content (and by that changing the syntax) most 
> likely need accompanying changes in clang itself.
>
> I noticed you have at least one other similar patch but I don't see the 
> changes I'd expect there - please let me know if I'm just missing something!
>
> Do the tests actually pass with this patch?

Thanks for the quick review. The tests do pass, it looks like there has been a 
patch that allowed the `ignorelist` options to be accepted by clang: 
https://reviews.llvm.org/D101832.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113211/new/

https://reviews.llvm.org/D113211

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to