jansvoboda11 added a comment.

Assuming the filesystem doesn't change during dependency scanning, this change 
keeps the consistency between stat/read calls for minimized files.

Thinking about it some more though, the original reason for reading files 
eagerly (even for stat calls) was most likely to avoid inconsistencies when the 
file changes on the filesystem between stat and read. Is that correct, 
@arphaman? If so, I think I should abandon this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114968/new/

https://reviews.llvm.org/D114968

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to