arphaman added a comment. In D114968#3168123 <https://reviews.llvm.org/D114968#3168123>, @dexonsmith wrote:
> In D114968#3167519 <https://reviews.llvm.org/D114968#3167519>, @jansvoboda11 > wrote: > >> Assuming the filesystem doesn't change during dependency scanning, this >> change keeps the consistency between stat/read calls for minimized files. >> >> Thinking about it some more though, the original reason for reading files >> eagerly (even for stat calls) was most likely to avoid inconsistencies when >> the file changes on the filesystem between stat and read. Is that correct, >> @arphaman? If so, I think I should abandon this patch. > > Agreed; that consistency is important. I don't think stat should be decoupled > from reading the file. Yes, exactly, it was to avoid the file system change inconsistencies. it should not be decoupled . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114968/new/ https://reviews.llvm.org/D114968 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
