carlosgalvezp added a comment. In D108560#3167838 <https://reviews.llvm.org/D108560#3167838>, @aaron.ballman wrote:
> In D108560#3167830 <https://reviews.llvm.org/D108560#3167830>, @carlosgalvezp > wrote: > >> Good catch! That explains the performance drop we observed as well. >> >> We are however currently relying on this feature so it would be sad to >> revert it. Would it be possible/make sense to enable/disable via CLI/config? > > I don't think that's a good initial approach. The command line flag ends up > living a weird life once we eventually fix the performance issues (then the > flag isn't necessary but we still have to maintain it until we can remove > it). I'm not strictly opposed to a flag, but I'd want that to be more of a > last resort than a first effort. I see the problem now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108560/new/ https://reviews.llvm.org/D108560 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
