That's what happens when you hit the column limit, when there is a column
limit. But do we really want every one-symbol import to wrap to 3 lines
when `ColumnLimit: 0`? Slash to force the user to unwrap every import, even
20-symbol 300-column imports, to a single line?
On Wed, Jan 5, 2022 at 12:13 PM MyDeveloperDay via Phabricator <
revi...@reviews.llvm.org> wrote:
> MyDeveloperDay added a comment.
>
> > Make JavaScriptWrapImports: true *always* wrap imports to multiple
> lines. This will be noisy and ugly.
>
> Isn't this what `prettier` does when effectively the ColumnLimit is
> exceeded.
>
> i.e.
>
> import { Controller, Get, Post, Req } from '@nestjs/common';
>
> becomes as I hit the 80 column mark
>
> `
> import {
> Controller,
> Get,
> Post,
> Req,
> Request,
> Param,
> Query,
> StreamableFile,
> Body,
> } from '@nestjs/common';
>
> So if ColumnLimit is 0 it should wrap them shouldn't it if
> `JavaScriptWrapImports: true`
>
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D116638/new/
>
> https://reviews.llvm.org/D116638
>
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
