andmis added a comment.

My guess that `ColumnLimit: 0` is rarely used for JS is based on the objective 
fact that JS import formatting is (IMO very) buggy with the column limit set 
that way, and it took several years for us to hear a bug report about it. And 
"we should not make assumptions about what people will want" applies just as 
well to the proposal of force-wrapping at >= 2 imports.

I agree that `AlwaysWrap`/`NeverWrap`/`LeaveExistingWraps` is clearer and 
better than `true`/`false`. But we still have no answer for the semantics of 
`LeaveExistingWraps` in edge cases. Are we saying that we should not merge this 
bugfix without figuring out the answer to the semantics question and/or 
changing the option to an enum?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116638/new/

https://reviews.llvm.org/D116638

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to