simon_tatham added a comment.
I ran another test of this patch, by trying the cross product of the following
cmake configuration choices (on a build targeting Windows, with
`LLVM_ENABLE_PROJECTS=clang`):
- `LLVM_EXPORT_SYMBOLS_FOR_PLUGINS` set to each of `ON` and `OFF`
- `CLANG_BUILD_EXAMPLES` set to each of `ON` and `OFF`
- `CLANG_PLUGIN_SUPPORT` set to each of `ON` and `OFF`
3 of those 8 cases failed.
- export-symbols OFF, build-examples ON, plugin-support OFF
- export-symbols OFF, build-examples ON, plugin-support ON
- export-symbols ON, build-examples ON, plugin-support OFF (which is the
configuration we're currently using downstream)
In all three cases, I saw errors such as this (suggesting that a plugin is
being added to the list of things to test even though it wasn't built):
CMake Error at cmake/modules/AddLLVM.cmake:1821 (add_dependencies):
The dependency target "AnnotateFunctions" of target "check-all" does not
exist.
Call Stack (most recent call first):
CMakeLists.txt:1134 (add_lit_target)
Perhaps not all of the 8 configurations in this cross product are actually
sensible? But if one of them is not sensible, it would be better to get a clear
error message saying why, than to have to debug things like the above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119591/new/
https://reviews.llvm.org/D119591
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
