ioeric marked 2 inline comments as done. ================ Comment at: unittests/Format/CleanupTest.cpp:258 @@ +257,3 @@ + auto CleanReplaces = cleanupAroundReplacements(Code, Replaces, Style); + EXPECT_TRUE((bool)CleanReplaces) + << llvm::toString(CleanReplaces.takeError()) << "\n"; ---------------- klimek wrote: > The explicit cast is unfortunate. Does this not have an .Ok() method or > something? unfortunately, the bool operator is the only way we got...
I think the idea is that Errors are always expected to be checked and handled (the destructor of llvm::Error asserts that an Error has been handled). http://reviews.llvm.org/D21601 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
