erichkeane added inline comments.

================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:963-964
+          Entity(Entity),
+          EvaluatingAConstraint(EvaluatingConstraint ||
+                                !SemaRef.CurContext->isDependentContext()) {}
 
----------------
ChuanqiXu wrote:
> I would like to see this in call site and a comment to tell us that we don't 
> want to evaluate constraints in dependent context.
So you want this logic moved to the call-sites?  Or am I misinterpreting that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to