zahiraam added inline comments.
================ Comment at: clang/lib/CodeGen/CGExprComplex.cpp:615 + ComplexPairTy result = VisitMinus(E, promotionTy); + return result; +} ---------------- rjmccall wrote: > This is not unpromoting if the original `PromotionType` is null. The idea for this change is that we will be coming to this function only if we are returning a "-operand". If we are in the middle of an expression (such as -f *a +b) we would be directly going to VisitMinus from ScalarExprEmitter::EmitPromod, from the switch branch of UnaryMinus and the promotiontype wouldn't be null. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
