svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land.
LGTM, thanks! ================ Comment at: clang/docs/ReleaseNotes.rst:676 + LLVM backend when generating SPIR-V binary. + Floating Point Support in Clang ---------------- Anastasia wrote: > svenvh wrote: > > Should we say anything about opaque pointers? Something like: > > > > ``` > > - Although LLVM has switched to opaque pointers with this release, SPIR-V > > generation still relies on typed pointers in this release. > > ``` > Sure, good point! I have added an item to clarify this. Does it look ok to > you? generation -> generator I'd say, which you can address at commit time. For the rest it looks good! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132473/new/ https://reviews.llvm.org/D132473 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
