beanz added inline comments.
================ Comment at: clang/lib/Sema/HLSLExternalSemaSource.cpp:243 + AST, MethodDecl->getDeclContext(), SourceLocation(), SourceLocation(), + &II, AST.UnsignedIntTy, + AST.getTrivialTypeSourceInfo(AST.UnsignedIntTy, SourceLocation()), ---------------- aaron.ballman wrote: > Should this be using a size type instead? As currently implemented it is an unsigned int. I should include the doc link in the description: https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/sm5-object-rwbuffer-operatorindex Eventually I think we'll need to introduce size types to HLSL, but we currently don't really use them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131268/new/ https://reviews.llvm.org/D131268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits