dblaikie added a comment.
Herald added a subscriber: abrachet.
Herald added a project: All.

FWIW, the existence of this flag and the TargetCXXABI abstraction (which 
predates the flag, but might otherwise be more simply factored/implemented with 
inheritance rather than switch tables) came up in discussion D135326 
<https://reviews.llvm.org/D135326> and D119051 
<https://reviews.llvm.org/D119051>.

(eg: the RecordLayoutBuilders are split by Itanium and Microsoft - but there's 
loads of triple checks throughout including for C++ layout choices (eg: 
`getBaseOrPreferredBaseAlignFromUnpacked`, empty base handling, etc) that 
aren't captured by the TargetCXXABI abstraction)

& so the question was where to put this next C++ Itanium ABI fix which is 
currently applied to Itanium in general, except for PS, Darwin, and Clang ABI 
<= 15.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85802/new/

https://reviews.llvm.org/D85802

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to