phosek added inline comments.
================ Comment at: compiler-rt/lib/xray/tests/CMakeLists.txt:68-80 + if (COMPILER_RT_HAS_LLVMXRAY OR COMPILER_RT_HAS_LLVMTESTINGSUPPORT) + if (LLVM_LINK_LLVM_DYLIB) + list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVM) + endif() + else() + if (COMPILER_RT_HAS_LLVMXRAY) + list(APPEND XRAY_UNITTEST_LINK_FLAGS -lLLVMXRay) ---------------- mgorny wrote: > phosek wrote: > > Rather than manually linking against libraries and their dependencies > > (which may change over time and break this code), we should use import > > targets provided by the LLVM CMake config: `LLVMXRay` and > > `LLVMTestingSupport`. That can be done in a follow up change though. > I actually wanted to do that but couldn't figure out how. Perhaps my approach > was wrong, as I was trying to get linked libraries out of target properties. I can take a look once this change lands, it might require changes to compiler-rt helpers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
