phosek added inline comments.
================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275
+ "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead")
+ get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY)
+ get_filename_component(LLVM_CMAKE_DIR "${LLVM_CMAKE_DIR}" DIRECTORY)
endif()
----------------
Is the assumption that `LLVM_CMAKE_DIR` is two directories up from
`LLVM_CONFIG_PATH`? If so, I'd consider leaving a comment here to make that
clear.
Is that also correct? In my build for example, I have `bin/llvm-config` and
`lib/cmake/llvm/LLVMConfig.cmake`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137024/new/
https://reviews.llvm.org/D137024
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
