hokein marked an inline comment as done.
hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:213
+ auto Highlights = getSemanticHighlightings(*AST);
+ if (LineRange) {
+ for (const auto HL : Highlights) {
----------------
kadircet wrote:
> we should print all the highlights when LineRange is missing. so maybe turn
> this into:
> ```
> auto Highlights = ...
> for(const auto HL : ..) {
> if(!LineRange || LineRange->contains(HL.R))
> vlog(...);
> }
> ```
I was going to say this likely introduces too much noise to the output log,
then I realized that we already did it for inlay hints, probably it is fine for
verbose log...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137063/new/
https://reviews.llvm.org/D137063
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
