tangyouling added a comment.

In D136436#3898394 <https://reviews.llvm.org/D136436#3898394>, @SixWeining 
wrote:

> In D136436#3898392 <https://reviews.llvm.org/D136436#3898392>, @tangyouling 
> wrote:
>
>> Is it acceptable to add the `non-prefix $`? if not, an alternative fix for 
>> the build failure is to add the `prefix $` in 
>> sanitizer_syscall_linux_loongarch64.inc
>
> People have different opinions. This may need long time to discuss and decide 
> (maybe in a broader place). So currently it's better to modify 
> `sanitizer_syscall_linux_loongarch64.inc` I think.

Ok, I will send a new Revision to fix sanitizer_syscall_linux_loongarch64.inc 
separately, but this Revision does not close and continue the discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136436/new/

https://reviews.llvm.org/D136436

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to