thetruestblue added a comment.

This breaks our use case. We run sanitizer tests built in a standalone build 
using an artifact toolchain that contains binaries only. 
Compiler-rt tests rely on the llvm tools binary being in the PATH.

This patch removes the logic that sets the binary tools dir using llvm-config. 
We don't have llvmConfig.cmake in our toolchain relied on llvm-config to 
set(LLVM_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}"directory.

We can work around this by setting the LLVM_TOOLS_BINARY_DIR directly (and 
potentially other paths... tbd).

But I think we need to reactor this cmake file so that this is considered a 
valid code path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137024/new/

https://reviews.llvm.org/D137024

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to