aaron.ballman added a comment. This looks like the right direction to me, but there's quite a few whitespace and formatting NFC changes in the patch. If you don't mind splitting those changes out into their own commit, that would be appreciated (feel free to land those changes without review given that they're only changing whitespace and other formatting).
================ Comment at: clang/tools/c-index-test/c-index-test.c:378 + const char *PrintQualifiedTypeNamesArg = "-print-qualified-type-names"; + const char *PrintQualifiedTypeNames = 0; + ---------------- ================ Comment at: clang/tools/c-index-test/c-index-test.c:1787 PrintCursor(cursor, NULL); + VisitorData *Data = (VisitorData *)d; PrintSingleTypeSize(T, " [type=%s] [typekind=%s]", " [sizeof=%lld]", ---------------- I'm not super familiar with c-index-test -- how certain are you that the client data will 1) be non-null, and 2) actually be a `VisitorData` pointer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138377/new/ https://reviews.llvm.org/D138377 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
