daltenty accepted this revision. daltenty added a comment. New revision LGTM, VisibleNoLinkage is typical reserved for types from inline functions so it doesn't seem sensible to return. Looking at the C++ standard, I'm not even convinced this is guaranteed to be the same object if the function doesn't have external linkage, so I think the guard is sensible.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128223/new/ https://reviews.llvm.org/D128223 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
