kiranchandramohan added a comment. Would it be possible to break this into a few patches like suggested below or similar?
1. Changed to using inlineConvertOmpRegions to generate target data associated region code inline in same block if possible. 2. Changed to calculating map_operand size from mlir type instead of llvm. Moved getSizeInBytes function back into OpenACC code as it is no longer shared. 3. Moved most of map_operands related codegen to OMPIRBuilder. Moved mapper_allocas related codegen to OMPIRBuilder. 4. Changed offload_sizes parameter to a global variable same as offload_maptypes to be more consistent with Clang generated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
