paulkirth added a comment. In D146987#4299353 <https://reviews.llvm.org/D146987#4299353>, @Orlando wrote:
> In D146987#4299081 <https://reviews.llvm.org/D146987#4299081>, @paulkirth > wrote: > >> @jmorse Sorry it took me a bit to set up, but I ran an experiment in our CI >> that reverted the change that disabled this as default and tried it for x86. >> It looks like this patch is working OK for us now: >> https://ci.chromium.org/raw/build/logs.chromium.org/fuchsia/led/paulkirth_google.com/df38ff794f44284ff34f63e5dc1f1d41b25225b1241c14eff15a9f0a4b189afb/+/build.proto?server=chromium-swarm.appspot.com >> >> I'm reasonably confident that should mean you won't run into issues. The >> caveat here is that I can't easily launch experiments across all >> combinations of platforms and hardware, so it's possible there may still be >> an issue. I think that's unlikely given how this has been manifesting, so >> I'd say you're good to try again in our perspective. > > Thank you for doing that, that's really helpful. Just to double check - that > is a non-LTO but otherwise optimised build of fuchsia? It's a standard optimized build of Fuchsia. Some parts will use LTO or ThinLTO. This is the CI that verifies our toolchain, so `debug` here refers to the compiler being a stage-2 compiler w/ asserts enabled and split debug info. The Fuchsia build also always compiles with complete (split) debug information for both kernel and userland. It may also be relevant that the majority of Fuchsia is built at `-Os`. The kernel typically builds at `-O2` or higher, but userland is always optimized for size. Empirically, we've had better size savings from `-Os` over `-Oz`, so incase that's relevant. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
