dmgreen added a comment.

My preference would be for fixing the code we have, not introducing new 
intrinsics. Intrinsics act as black-boxes for the optimizer, and I'm pretty 
sure I've heard of cases in the past of the compiler optimizing the 
or/and/xor's to nicer sequences of instructions. It would be a shame to lose 
that.

The number of instructions in bsl is quite high compared to many intrinsics, 
they probably have a high chance of going wrong. But if we know of ways to 
optimize them (through shouldSinkOperands), then that would be my preference. 
It can end up helping all cases, not just the intrinsics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147266/new/

https://reviews.llvm.org/D147266

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to