carlosgalvezp accepted this revision. carlosgalvezp added a comment. This revision is now accepted and ready to land.
> Separating the changes into two patches would only prolong this process and > potentially delay the completion of this task. I understand the concern, but in practice it's actually the other way around. 2 small and easy to review patches are more likely to get reviewed quickly than the same patches combined into 1 big patch. The easier you make life for reviewers, the more likely they are to be willing / have time to review a patch. When I post patches, I often try and reflect about what else I can remove or make more obvious/readable to make reviewer's life easier and improve my chances of getting a quick review. I understand it's more work on the author side, but from experience I've found there's a net gain to doing it. Anyway, the patch is indeed fairly easy to review so I'll just approve it, thank you for the contribution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148995/new/ https://reviews.llvm.org/D148995 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
