This revision was automatically updated to reflect the committed changes.
Closed by commit rG6ccb8061724f: [clang-tidy] Extract areStatementsIdentical
(authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148995/new/
https://reviews.llvm.org/D148995
Files:
clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
clang-tools-extra/clang-tidy/utils/ASTUtils.cpp
clang-tools-extra/clang-tidy/utils/ASTUtils.h
Index: clang-tools-extra/clang-tidy/utils/ASTUtils.h
===================================================================
--- clang-tools-extra/clang-tidy/utils/ASTUtils.h
+++ clang-tools-extra/clang-tidy/utils/ASTUtils.h
@@ -36,6 +36,10 @@
// FIXME: false-negative if the entire range is fully expanded from a macro.
bool rangeCanBeFixed(SourceRange Range, const SourceManager *SM);
+// Check if statements are same
+bool areStatementsIdentical(const Stmt *FirstStmt, const Stmt *SecondStmt,
+ const ASTContext &Context, bool Canonical = false);
+
} // namespace clang::tidy::utils
#endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
Index: clang-tools-extra/clang-tidy/utils/ASTUtils.cpp
===================================================================
--- clang-tools-extra/clang-tidy/utils/ASTUtils.cpp
+++ clang-tools-extra/clang-tidy/utils/ASTUtils.cpp
@@ -88,4 +88,29 @@
!utils::rangeContainsMacroExpansion(Range, SM);
}
+bool areStatementsIdentical(const Stmt *FirstStmt, const Stmt *SecondStmt,
+ const ASTContext &Context, bool Canonical) {
+ if (!FirstStmt || !SecondStmt)
+ return false;
+
+ if (FirstStmt == SecondStmt)
+ return true;
+
+ if (FirstStmt->getStmtClass() != FirstStmt->getStmtClass())
+ return false;
+
+ if (isa<Expr>(FirstStmt) && isa<Expr>(SecondStmt)) {
+ // If we have errors in expressions, we will be unable
+ // to accurately profile and compute hashes for each statements.
+ if (llvm::cast<Expr>(FirstStmt)->containsErrors() ||
+ llvm::cast<Expr>(SecondStmt)->containsErrors())
+ return false;
+ }
+
+ llvm::FoldingSetNodeID DataFirst, DataSecond;
+ FirstStmt->Profile(DataFirst, Context, Canonical);
+ SecondStmt->Profile(DataSecond, Context, Canonical);
+ return DataFirst == DataSecond;
+}
+
} // namespace clang::tidy::utils
Index: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
===================================================================
--- clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
+++ clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp
@@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//
#include "LoopConvertUtils.h"
+#include "../utils/ASTUtils.h"
#include "clang/Basic/IdentifierTable.h"
#include "clang/Basic/LLVM.h"
#include "clang/Basic/Lambda.h"
@@ -190,13 +191,7 @@
/// Returns true when two Exprs are equivalent.
bool areSameExpr(ASTContext *Context, const Expr *First, const Expr *Second) {
- if (!First || !Second)
- return false;
-
- llvm::FoldingSetNodeID FirstID, SecondID;
- First->Profile(FirstID, *Context, true);
- Second->Profile(SecondID, *Context, true);
- return FirstID == SecondID;
+ return utils::areStatementsIdentical(First, Second, *Context, true);
}
/// Returns the DeclRefExpr represented by E, or NULL if there isn't one.
Index: clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
+++ clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp
@@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//
#include "BranchCloneCheck.h"
+#include "../utils/ASTUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatchFinder.h"
#include "clang/Analysis/CloneDetection.h"
@@ -16,26 +17,6 @@
using namespace clang;
using namespace clang::ast_matchers;
-/// Returns true when the statements are Type I clones of each other.
-static bool areStatementsIdentical(const Stmt *LHS, const Stmt *RHS,
- const ASTContext &Context) {
- if (isa<Expr>(LHS) && isa<Expr>(RHS)) {
- // If we have errors in expressions, we will be unable
- // to accurately profile and compute hashes for each
- // of the left and right statements.
- const auto *LHSExpr = llvm::cast<Expr>(LHS);
- const auto *RHSExpr = llvm::cast<Expr>(RHS);
- if (LHSExpr->containsErrors() && RHSExpr->containsErrors()) {
- return false;
- }
- }
-
- llvm::FoldingSetNodeID DataLHS, DataRHS;
- LHS->Profile(DataLHS, Context, false);
- RHS->Profile(DataRHS, Context, false);
- return (DataLHS == DataRHS);
-}
-
namespace {
/// A branch in a switch may consist of several statements; while a branch in
/// an if/else if/else chain is one statement (which may be a CompoundStmt).
@@ -55,8 +36,9 @@
// NOTE: We strip goto labels and annotations in addition to stripping
// the `case X:` or `default:` labels, but it is very unlikely that this
// would cause false positives in real-world code.
- if (!areStatementsIdentical(LHS[I]->stripLabelLikeStatements(),
- RHS[I]->stripLabelLikeStatements(), Context)) {
+ if (!tidy::utils::areStatementsIdentical(LHS[I]->stripLabelLikeStatements(),
+ RHS[I]->stripLabelLikeStatements(),
+ Context)) {
return false;
}
}
@@ -89,8 +71,8 @@
if (!isa<IfStmt>(Else)) {
// Just a simple if with no `else if` branch.
- if (areStatementsIdentical(Then->IgnoreContainers(),
- Else->IgnoreContainers(), Context)) {
+ if (utils::areStatementsIdentical(Then->IgnoreContainers(),
+ Else->IgnoreContainers(), Context)) {
diag(IS->getBeginLoc(), "if with identical then and else branches");
diag(IS->getElseLoc(), "else branch starts here", DiagnosticIDs::Note);
}
@@ -130,9 +112,9 @@
int NumCopies = 1;
for (size_t J = I + 1; J < N; J++) {
- if (KnownAsClone[J] ||
- !areStatementsIdentical(Branches[I]->IgnoreContainers(),
- Branches[J]->IgnoreContainers(), Context))
+ if (KnownAsClone[J] || !utils::areStatementsIdentical(
+ Branches[I]->IgnoreContainers(),
+ Branches[J]->IgnoreContainers(), Context))
continue;
NumCopies++;
@@ -160,7 +142,8 @@
if (const auto *CO = Result.Nodes.getNodeAs<ConditionalOperator>("condOp")) {
// We do not try to detect chains of ?: operators.
- if (areStatementsIdentical(CO->getTrueExpr(), CO->getFalseExpr(), Context))
+ if (utils::areStatementsIdentical(CO->getTrueExpr(), CO->getFalseExpr(),
+ Context))
diag(CO->getQuestionLoc(),
"conditional operator with identical true and false expressions");
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
