eddyz87 added a comment. In D143967#4346934 <https://reviews.llvm.org/D143967#4346934>, @dfaust wrote:
> In D143967#4343841 <https://reviews.llvm.org/D143967#4343841>, @eddyz87 wrote: > >> Changes to avoid attaching type tags to DWARF derived types for >> const/volatile/restrict qualifiers. > > I just tested this locally and can confirm it LGTM in terms of implementing > the DWARF format we've been discussing and agreed upon. > Also compared against my WIP patches implementing the same in GCC, and looks > like it is all consistent (apart from one known bug in my patches) Heads-up, it currently fails on the following example: #define __rcu __attribute__((btf_type_tag("rcu"))) struct cred; const struct cred *cred; void commit_creds() { cred = (typeof(*cred) __rcu *)(0); } I'm working on the fix. Also I missed the fact that D145891 <https://reviews.llvm.org/D145891> (actual BTF generation) needs adjustment as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143967/new/ https://reviews.llvm.org/D143967 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
