aaron.ballman added a comment. My primary concern with this is that we're calling these stable IDs -- they're not really stable IDs, they're internal implementation details that we change from time to time. So what happens when we rename `ext_foo_bar` into `warn_foo_bar` as far as SARIF is concerned? Does it matter, or are we setting some tools up for problems because they'll want to map between the old name and the new name if they're the "same diagnostic" as before?
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146654/new/ https://reviews.llvm.org/D146654 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
