sbc100 added a comment.

In D151820#4385393 <https://reviews.llvm.org/D151820#4385393>, @dschuff wrote:

> I guess this is basically the C version of max_align_t so it should match.

Yes, it should match.   Having `__BIGGEST_ALIGNMENT__` be 16 for emscripten 
doesn't make any sense right now.

> but... this still has the potential to break things.
> e.g. it will change the allocation in 
> https://github.com/google/XNNPACK/blob/master/src/xnnpack/allocator.h#L66
> ISTR that was one of the projects that had an issue with this the first time 
> around?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151820/new/

https://reviews.llvm.org/D151820

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to