sbc100 added a comment. In D151820#4385512 <https://reviews.llvm.org/D151820#4385512>, @dschuff wrote:
>> I don't think it will change anything in that code since >> `__BIGGEST_ALIGNMENT__ >= XNN_ALLOCATION_ALIGNMENT` will still hold true >> both before and after this change (XNN_ALLOCATION_ALIGNMENT == 4 on wasm) > > Right, that check causes XNN_ALLOCATION_ALIGNMENT to be ignored in favor of > using clang's `_builtin_alloca()` which will be changed by this CL. I don't think it will since `__BIGGEST_ALIGNMENT__ >= XNN_ALLOCATION_ALIGNMENT` will remain true after this change.. so this change should have no effect on that code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151820/new/ https://reviews.llvm.org/D151820 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
