sepavloff marked 8 inline comments as done. sepavloff added a comment. In D152351#4403904 <https://reviews.llvm.org/D152351#4403904>, @aaron.ballman wrote:
> In D152351#4402785 <https://reviews.llvm.org/D152351#4402785>, @arsenm wrote: > >> Also should get mentioned in the builtin docs and release notes > > +1, also, should there be named constants for the mask values? I don't know where these constants could be placed. ================ Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +_Bool check_isfpclass_finite(float x) { ---------------- arsenm wrote: > Can you also add a half test, also vectors Half is added. But vectors cannot, because in this case result is also a vector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
