shafik added inline comments.
================ Comment at: clang/lib/Sema/SemaExprCXX.cpp:4003-4004 + // that are not referenced or used later. e.g.: if (int var = init()); + ConditionVar->setReferenced(false); + ConditionVar->setIsUsed(false); + ---------------- tbaeder wrote: > shafik wrote: > > > That seem a bit over the top given that it's the only boolean parameter. Yeah, in this case it is blindingly obvious but I do see many cases in the code where folks use `bugprone-argument-comment` for single bool parameters and I just use it everywhere for consistency sake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
