stefanp accepted this revision as: stefanp. stefanp added a comment. This revision is now accepted and ready to land.
I think this patch makes sense to me. LGTM. ================ Comment at: llvm/test/CodeGen/PowerPC/check-aix-small-local-exec-tls-opt.ll:15 + +; Make sure that the test was actually compiled successfully after using the +; -maix-small-local-exec-tls option. ---------------- DiggerLin wrote: > since the patch only add a new option "aix-small-local-exec-tls" , the the > backend implementation for this option in not in the patch, the behavior of > the CodeGen do not change in the patch, I do not think we need the test case. I would actually prefer to have a test case here. We do need to check to make sure that the backend produces the correct error on Linux and produces valid codegen on AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155544/new/ https://reviews.llvm.org/D155544 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
