hubert.reinterpretcast added a comment.

Patch should not land before back-end patch. I also suggest having the patch 
incorporate the new option into the Clang release notes before it lands.



================
Comment at: llvm/lib/Target/PowerPC/PPC.td:324
+                   "Produce a faster access sequence for local-exec TLS "
+                   "variables where the offset from the thread pointer value "
+                   "is encoded as an immediate operand (AIX 64-bit only). "
----------------
As agreed offline:
thread pointer value -> TLS base



================
Comment at: llvm/lib/Target/PowerPC/PPCSubtarget.cpp:127
+
+  if ((!TargetTriple.isOSAIX()) && HasAIXSmallLocalExecTLS)
+    report_fatal_error(
----------------
There should be no confusion over how tightly `!` binds over `&&`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155544/new/

https://reviews.llvm.org/D155544

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to