zyounan added inline comments.
================
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1407
R.FunctionCanBeCall =
CurrentClassScope &&
----------------
zyounan wrote:
> The current heuristic results in the following:
>
> ```
> struct Base {
> void foo(int);
> };
> struct Derived : Base {
> void foo(float);
> };
>
> int main() {
> Derived d;
> d.Base::^ // FunctionCanBeCall for `foo` is false.
> }
> ```
>
> In situations where it is intended to invoke base member functions hidden by
> subclasses, we shouldn't remove parentheses, IMO.
D156605 to address this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155370/new/
https://reviews.llvm.org/D155370
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
