benlangmuir added a subscriber: vsapsai. benlangmuir added a comment. CC @vsapsai since he was also making name vs. name-as-requested change in modules
================ Comment at: clang/include/clang/Serialization/ModuleFile.h:72 + bool TopLevel; + bool ModuleMap; }; ---------------- Is there something using this new split? It seems like every user is using `&&` for these ================ Comment at: clang/lib/Serialization/ASTReader.cpp:2411 bool Transient = FI.Transient; - StringRef Filename = FI.Filename; + StringRef Filename = FI.FilenameAsRequested; uint64_t StoredContentHash = FI.ContentHash; ---------------- It's not clear to me why this one changed ================ Comment at: clang/lib/Serialization/ASTReader.cpp:9323 +void ASTReader::visitInputFileInfos( + serialization::ModuleFile &MF, bool IncludeSystem, ---------------- Can we rewrite `visitInputFiles` on top of this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157066/new/ https://reviews.llvm.org/D157066 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
