benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/include/clang/Serialization/ModuleFile.h:72 + bool TopLevel; + bool ModuleMap; }; ---------------- jansvoboda11 wrote: > benlangmuir wrote: > > Is there something using this new split? It seems like every user is using > > `&&` for these > You're right. I recall needing this on (now probably abandoned) patch, so I > thought I might as well add the extra bit now, sine I'm changing the format > anyways. I'm fine with removing this. It's fine, I was just making sure I didn't miss something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157066/new/ https://reviews.llvm.org/D157066 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits