aaron.ballman added a comment.

In D153156#4607576 <https://reviews.llvm.org/D153156#4607576>, @hans wrote:

> Given the concerns raised (the PRIuS one in https://godbolt.org/z/v3boc9E6T 
> seems like a good example), and that the fix in D158372 
> <https://reviews.llvm.org/D158372> doesn't seem straight-forward, could this 
> be reverted to unbreak things until a revised version is ready?
>
> @aaron.ballman what do you think?

I agree this should be reverted from 17.x so we have more time to consider an 
appropriate path forward. Supporting evidence that this will likely be 
disruptive: 
https://sourcegraph.com/search?q=context:global+%5E%28%22%5B%5E%22%5D%2B%22PRI.*%29%24+lang:C%2B%2B+-file:.*test.*&patternType=regexp&case=yes&sm=0&groupBy=repo


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153156/new/

https://reviews.llvm.org/D153156

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to