ioeric marked an inline comment as done.

Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+      continue;
+    const std::string &FilePath = FileAndNsMoves.first;
+    auto &Replaces = FileToReplacements[FilePath];
omtcyfz wrote:
> `StringRef` here too.
If this was a `StringRef`, then each map access would require an implicit 
conversion from `StringRef` to `std::string`, which is expensive. And this is 
already a reference anyway.

cfe-commits mailing list

Reply via email to