omtcyfz added inline comments.
Comment at: change-namespace/ChangeNamespace.cpp:448
@@ +447,3 @@
+ const std::string &FilePath = FileAndNsMoves.first;
+ auto &Replaces = FileToReplacements[FilePath];
> omtcyfz wrote:
> > `StringRef` here too.
> If this was a `StringRef`, then each map access would require an implicit
> conversion from `StringRef` to `std::string`, which is expensive. And this is
> already a reference anyway.
Ah, I see. Yes, that's true. Sorry.
cfe-commits mailing list